Skip to content

feat(showcase): new page to display config #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat(showcase): new page to display config #201

wants to merge 19 commits into from

Conversation

@DeadEnglish
Copy link
Contributor

@DeadEnglish DeadEnglish commented Dec 28, 2024 •
edited
Loading

What does this do?

Starting the work on #125, getting the general layout correct.

  • New page for showcase
    • Includes list item component
  • New modal component
  • Adding className prop to CodeBlock to add custom styling
  • Adding className prop to TagList to add custom styling

TODO

  • A better way to hide route from production if we want to merge before this page is ready (I don't like large PRs 😭)
  • Tag component (maybe a different PR) See feat(tag): new component #203
  • Modal design
    • Better closing element for modal
  • Content structure
  • Fix pre-render error on modal

Videos/Images

Showcase list

Screen.Recording.2024-12-28.at.13.10.32.mp4

Working example

Screen.Recording.2025-02-01.at.12.49.14.mp4

@vercel
Copy link

vercel bot commented Dec 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:54am

@DeadEnglish
Copy link
Contributor Author

DeadEnglish commented Dec 28, 2024

See #203 for Tag component

BrandonRomano
BrandonRomano reviewed Dec 28, 2024
View reviewed changes
@BrandonRomano
Copy link
Member

BrandonRomano commented Jan 27, 2025

For posterity: shared on discord. The direction of this PR so far is good!

@DeadEnglish DeadEnglish marked this pull request as ready for review February 3, 2025 16:01
@DeadEnglish DeadEnglish marked this pull request as draft February 3, 2025 16:05
@DeadEnglish DeadEnglish marked this pull request as ready for review February 10, 2025 08:51
@DeadEnglish DeadEnglish changed the title feat(showcase): initial pass of showcase page [WIP] feat(showcase): new page to display config Feb 10, 2025
@BrandonRomano
Copy link
Member

BrandonRomano commented Feb 26, 2025

@DeadEnglish I missed you flipped this to ready for review. I'll try to review this soon :)

@BrandonRomano BrandonRomano self-assigned this Feb 26, 2025
@DeadEnglish
Copy link
Contributor Author

DeadEnglish commented Feb 27, 2025

Cheers, also no rush on the review, I've been somewhat afk due to work 😅

@DeadEnglish
Copy link
Contributor Author

DeadEnglish commented Apr 15, 2025 •
edited
Loading

Hey @BrandonRomano it's been a fair while and I've been busy at work 😅. Would appreciate a review of any kind when you get a chance 😄

@BrandonRomano
Copy link
Member

BrandonRomano commented May 8, 2025 •
edited
Loading

Sorry @DeadEnglish it has been quite a while. I've also been busy with work, but I will pen you down to try to get a review here tonight!

Edit: I will get to it this weekend! Hah sorry having a week.

BrandonRomano
BrandonRomano approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@BrandonRomano BrandonRomano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good & clean work. Nice work @DeadEnglish. Sorry I literally took months to review it 😭.

I think the only thing I can think of is potentially wanting to think about how contributors can add in a new showcase item. (e.g. perhaps adding a small README into the showcase directory). I imagine this will get filled up quickly!

@DeadEnglish
Copy link
Contributor Author

DeadEnglish commented May 27, 2025

Also been super busy so no worries, thanks for the review!

Will update with a readme at some point this week and hopefully we can start showcasing some configs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrandonRomano BrandonRomano BrandonRomano approved these changes

Assignees

@BrandonRomano BrandonRomano

Labels

website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeadEnglish @BrandonRomano